Made value type of the messages a template parameter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder how hard it would be to add the features in CDBoost that are missing in Cadmium and keep a single line of development. Do you have an estimation? |
|
I do not know. @daniellaniyo do you have an estimation? |
|
@cruizm No, my memory is not fresh enough to give an accurate estimate. I think it's worth investigating though and keep the same base for both if possible. Otherwise, this will require porting fixes, features to different repos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the values of the messages sent can be of any type (it use to be hardcoded for ints). I had to set the VALUE template parameter on ports, driver and erunner classes. The template parameter default was set to int for retrocompatibility.
Also I removed the template parameter FEL from erunner because it was unused.